-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Enhance Twitter Data Saver demo #83
Comments
Yes, it's clear. |
I've updated the client hint version accordingly since I thought it would take 20 minutes or so. |
FYI: I think the codebase is a bit messy as I just adopted react-tweet project and did not refactor it because I thought it would take quite some time to refactor adequately. |
No worries. Given this is a demo, I think that is okay. Could we update the tweet text, avatar and username for that entry to match the tweet I linked to as well? Would it be hard to also add this change to the hooks demo? |
I think it's not so difficult. After adding, we might have to adjust the view on desktop and mobile. |
Looks like this project does not quite fit for mobile responsive view, although I tweaked a bit in the past. I've checked that it's okay on Sumsung Galaxy 9 but not guaranteed for all mobile devices. |
This looks perfect, Anton! Thank you! |
I believe our Twitter Data Saver demo also included support for embedded videos in Tweets: https://github.com/GoogleChromeLabs/adaptive-loading/blob/master/react-twitter-save-data-loading(hook)/src/components/Tweet/Video.js
If we have time, I would like for us to enhance the current Hooks demo so that the 4th sample tweet is https://twitter.com/mrdoob/status/1131817655134896128. This would allow us to demonstrate what a LQIP/blurred image for a video entry would look like (just an image) when data saver is on and we can then load the video on tap the way Twitter's current experience works.
The video for this tweet is attached 📦
main-video2.mp4.zip
cc @anton-karlovskiy
The text was updated successfully, but these errors were encountered: