-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enhanced twitter #85
Merged
addyosmani
merged 10 commits into
GoogleChromeLabs:master
from
anton-karlovskiy:feature/enhanced-twitter
Nov 10, 2019
Merged
Feature/enhanced twitter #85
addyosmani
merged 10 commits into
GoogleChromeLabs:master
from
anton-karlovskiy:feature/enhanced-twitter
Nov 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's ready for review. |
Thanks, Anton! Will review today. Did you see my comment from #83 (comment)? |
Sure, let me handle it. |
It's ready. |
…k and feed as the original video tweet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@addyosmani
Please check the current status.
https://adaptive-loading.web.app/react-twitter-save-data-loading(hook)
It's almost done. Just UI fixing on mobile for video element is left for now.
FYI: As I reported earlier, the original react-tweet project code is not so clean and structured, it has taken some time to implement the video feature.