Bugfix/deployment issue #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Anton. After landing two of the other PRs from this week, we will need to rebase this one against master to move ahead with it. Let me know if you have time to, otherwise will do this myself later in the day. |
|
anton-karlovskiy
force-pushed
the
bugfix/deployment-issue
branch
from
11d8ab1
to
18cd1fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written some doc in README for multiple deployment using firebase function.
FYI: react-movie and react-shrine also work once deployed in this way. We can use more readable URLs for deployed sub project.