Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium on Linux fails to save files #118

Closed
tmcw opened this issue Jun 28, 2022 · 4 comments
Closed

Chromium on Linux fails to save files #118

tmcw opened this issue Jun 28, 2022 · 4 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Jun 28, 2022

So, I'm not an expert on the differences between Chrome and Chromium and any possible native fs difference between Mac, Linux, etc. but I've gotten reports from the field and can replicate locally in a Ubuntu VM that attempting to use browser-fs-access in Chromium on Ubuntu consistently produces AbortError failures:

CleanShot 2022-06-28 at 10 28 05@2x

This can be replicated on the demo as well as in my application. As far as I can tell, Chromium on Linux advertises support for the native filesystem API and breaks if you try to use it.

@tomayac
Copy link
Member

tomayac commented Jun 28, 2022

Interesting, I can reproduce this, too. I need to investigate what might be causing this.

@tmcw
Copy link
Contributor Author

tmcw commented Jun 28, 2022

Did some digging, seems like it tracks back to these issues: https://bugs.chromium.org/p/chromium/issues/detail?id=1264708#c10

And it looks like the solution is that Chromium/Linux requires the description parameter. Tested that and it seems to fix behavior. I think on the browser-fs-access side (assuming that Chromium doesn't fix its behavior), a solution would be either to make the description member of the options argument required, or to have a non-empty default value for Description.

@tomayac
Copy link
Member

tomayac commented Jun 28, 2022

Oh, nice. This would be an easy fix. In meeting all of the rest of today, but will definitely look tomorrow.

@tomayac
Copy link
Member

tomayac commented Jun 29, 2022

Confirmed working!

Screen Shot 2022-06-29 at 13 23 50

ngyikp added a commit to chicory-pizza/chicory-data that referenced this issue Jul 3, 2022
description needs to be set to workaround Chrome on Linux bug, use a better default description than 'Files'

GoogleChromeLabs/browser-fs-access#118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants