Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web share target support - string resources save #377

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Web share target support - string resources save #377

merged 1 commit into from
Oct 27, 2020

Conversation

chenlevy24
Copy link
Contributor

@chenlevy24 chenlevy24 commented Oct 27, 2020 •
edited by andreban
Loading

Now we save the share target data as a string resource.

Moves forward with #21

PEConn
PEConn approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PEConn PEConn merged commit 618cdde into GoogleChromeLabs:master Oct 27, 2020
@andreban andreban mentioned this pull request Oct 28, 2020
Closed
@andreban andreban added the enhancement New feature or request label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenlevy24 @PEConn @andreban