Commented out share_target implementation #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The share_target implementation is breaking the build. This PR fixes what is breaking it. We also set the shareTarget variable to `undefined`, effectivelly disabling the feature. The reason beint that no validation is being done in the value read from the Web Manifest, which can potentlially generate an invalid TWA Manifest.
PEConn
approved these changes
Oct 30, 2020
packages/core/src/lib/TwaManifest.ts
Outdated
| @@ -297,7 +297,7 @@ export class TwaManifest { | |||
| features: { | |||
| locationDelegation: {enabled: DEFAULT_ENABLE_LOCATION}, | |||
| }, | |||
| shareTargetJson: JSON.stringify(webManifest['share_target']), | |||
| shareTarget: undefined, // webManifest['share_target'], | |||
There was a problem hiding this comment.
I don't really like checking in commented out code. Potentially what we could have is a comment linking to a bug or issue explaining why it's undefined.
There was a problem hiding this comment.
Removed the commented-out code and added a comment. I want to avoid having broken things in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The share_target implementation is breaking the build. This PR
fixes what is breaking it.
We also set the shareTarget variable to
undefined, effectivelydisabling the feature. The reason being that no validation is
being done in the value read from the Web Manifest, which can
potentially generate an invalid TWA Manifest.
Related to #21