Add a warning for the play family policy. #562
Conversation
This adds a warning for the Google Play Family Policy to let developers know about being in compliance and also provides a link for them to visit to find out more information. Fixes GoogleChromeLabs#545
|
@andreban I took a shot at addressing #545 with this Cl. The only challenge is that when I run the tool from VSCode, it looks like the warning may get cropped off. See this screenshot which shows the warning:
and this is the screenshot of what it looks like in my terminal after running the tool: I am wondering if its better to have some sort of acknowledge the message or something rather than just posting a warning that may get cropped by the terminal. Is this similar to what you had in mind? Do you have a preferred link to use? |
|
Penny was able to provide this link : https://support.google.com/googleplay/android-developer/answer/9893335 and with a little guidance the policy can be found under family policy requirements - app functionality regarding web views. What do you think of picking one link over the other? |
packages/cli/src/lib/strings.ts
Outdated
| @@ -368,6 +369,11 @@ the PWA: | |||
| promptVersionCode: 'Starting version code for the new app version:', | |||
| promptUpdateProject: 'There are changes in twa-manifest.json. ' + | |||
| 'Would you like to apply them to the project before building?', | |||
| warnFamilyPolicy: bold(red('WARNING: ')) + 'Trusted Web Activities are currently incompatible' + | |||
There was a problem hiding this comment.
Looks good. I wonder if yellow is better for warning, as red can lead developers to think its an error/
|
What do you think of the yellow @andreban ? |
This adds a warning for the Google Play Family Policy to let developers
know about being in compliance and also provides a link for them to
visit to find out more information.
Fixes #545