update upgrades versionCode and versionName
#96
Conversation
- Renamed `appVersion` to `appVersionName` on `TwaManifest`. - Added `appVersionCode` to `TwaManifest. - Updated the template project to use `appVersionName` and `appVersionCode` from the TWA Manifest. - Added new option `skipVersinUpgrade` to `update`, to regenerate project without updating versions. - Added new option `appVersionName` to set a specific version name when updating the project - `update` generates new versions by increasing `appVersionCode` by 1. When generating a new `appVersionName`, the value of `--appVersionName` is used if set. Otherwise, an attempt to generate it from the `appVersionCode` is made. If not possible, the user is prompted to input a version name.
There was a problem hiding this comment.
So, if I understand correctly, the model here is that developers will create their TWA with llama-pack and then occasionally run update to create a new one with any features we may have added to the template project?
What about a developer who wants to change their TWA? Such as using a better icon or fixing a typo in their app name?
I'm wondering if the versions that llama-pack should have as a default should be something like 10, 20, 30, 40, which would allow developers to push a few updates and then the next time we add a feature, everything will play nicely.
src/cli/cmds/update.ts
Outdated
| const previousAppVersionCode = twaManifest.appVersionCode; | ||
| const appVersionCode = twaManifest.appVersionCode + 1; | ||
|
|
||
| // If a version was passed ar parameter, use it. |
|
That's a good question. For developers who are modifying the project outside llama-pack, it becomes really hard for us to understand what has changed and update the project accordingly. Ideally, If customising externally, they should probably move to developing in Android Studio. |
|
Created #97 for a future merge command |
appVersiontoappVersionNameonTwaManifest.appVersionCodeto `TwaManifest.appVersionNameandappVersionCodefrom the TWA Manifest.skipVersinUpgradetoupdate, to regenerateproject without updating versions.
appVersionNameto set a specific version namewhen updating the project
updategenerates new versions by increasingappVersionCodeby 1. When generating a new
appVersionName, the value of--appVersionNameis used if set. Otherwise, an attempt togenerate it from the
appVersionCodeis made. If not possible,the user is prompted to input a version name.
Closes #74
Closes #3