Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carlo app should not open all links #141

Open
alexkozy opened this issue Mar 6, 2019 · 0 comments
Open

carlo app should not open all links #141

alexkozy opened this issue Mar 6, 2019 · 0 comments

Comments

@alexkozy
Copy link
Contributor

alexkozy commented Mar 6, 2019

Steps:

  1. close all Chrome instances,
  2. run carlo app that uses stable.
  3. run open https://google.com from terminal.

Expected: link open in Chrome with default profile.
Actual: carlo app gets window event and by default will open new window with its profile.

At the same time if I run the same carlo app twice, I expect window event in first app instance.
I believe that something scary will happen if I open two different carlo apps - I have not checked it yet.

In ideal world I wish to have some Chrome flag, let's call it --carlo-app-id and then Chrome will uses current Chrome iff this id is equal otherwise it will try another running Chrome instance. Carlo will generates something random enough for each app and bright future will be here.

alexkozy added a commit to GoogleChromeLabs/ndb that referenced this issue Jun 20, 2019
As long as carlo has issue 141 [1] we can not use it with stable or
canary.
drive-by: added nice icon.

[1] GoogleChromeLabs/carlo#141
alexkozy added a commit to GoogleChromeLabs/ndb that referenced this issue Jun 20, 2019
As long as carlo has issue 141 [1] we can not use it with stable or
canary.
drive-by: added nice icon.

[1] GoogleChromeLabs/carlo#141
alexkozy added a commit to GoogleChromeLabs/ndb that referenced this issue Jun 20, 2019
As long as carlo has issue 141 [1] we can not use it with stable or
canary.
drive-by: added nice icon.

[1] GoogleChromeLabs/carlo#141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant