Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github App for the devrel reviews and approvals workflow #12

Merged
merged 16 commits into from Apr 14, 2022

Conversation

devnook
Copy link
Contributor

@devnook devnook commented Apr 11, 2022

Copy link

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! None of these comments are huge issues, so I think we'll be able to go forward with this approach in general!

approvals/app.js Outdated Show resolved Hide resolved
approvals/app.js Show resolved Hide resolved
approvals/app.js Outdated Show resolved Hide resolved
approvals/app.js Outdated Show resolved Hide resolved
approvals/app.js Outdated Show resolved Hide resolved
test/approvals/app.test.js Show resolved Hide resolved
test/approvals/app.test.js Show resolved Hide resolved
test/approvals/app.test.js Show resolved Hide resolved
test/approvals/fixtures/config.yml Outdated Show resolved Hide resolved
test/approvals/app.test.js Show resolved Hide resolved
@devnook
Copy link
Contributor Author

devnook commented Apr 13, 2022

PTAL

@jeffposnick jeffposnick self-requested a review April 13, 2022 18:22
Copy link

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few optional comments—this PR is mergeable as-is, so feel free to do that if you want to get the system set up sooner rather than later. You can address the feedback in follow-up PRs or just ignore it.

package.json Show resolved Hide resolved
server.js Show resolved Hide resolved
server.js Show resolved Hide resolved
name: request.headers['x-github-event'],
payload: request.body
});
response.send(200);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that the non-200 responses show up with the error in the body in a GitHub Actions dashboard, based on the info in that blog post. So it could help with debugging even though Glitch doesn't expose the logs.

But I've never tried that out, and we don't need to block the PR on that.

@devnook devnook merged commit eb5fdc4 into GoogleChromeLabs:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants