New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github App for the devrel reviews and approvals workflow #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! None of these comments are huge issues, so I think we'll be able to go forward with this approach in general!
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few optional comments—this PR is mergeable as-is, so feel free to do that if you want to get the system set up sooner rather than later. You can address the feedback in follow-up PRs or just ignore it.
name: request.headers['x-github-event'], | ||
payload: request.body | ||
}); | ||
response.send(200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that the non-200 responses show up with the error in the body in a GitHub Actions dashboard, based on the info in that blog post. So it could help with debugging even though Glitch doesn't expose the logs.
But I've never tried that out, and we don't need to block the PR on that.
App currently deployed at https://glitch.com/edit/#!/ash-wonderful-raja
Example repo with the app installed: https://github.com/devnook/developer.chrome.com/
Example config file: https://github.com/devnook/developer.chrome.com/blob/main/.github/chrome-devrel-bot.yml
Example PR: https://github.com/devnook/developer.chrome.com/pull/3