Stop installing headers from our libraries into the common place #132

emaxx-google · 2020-06-22T12:41:47Z

Currently, the build process is organized in a way that each sub-library (like //common/cpp) is built separately and then has its .lib+.h files installed into a common place (in the NaCl environment). Copying the headers is managed via a separate fake "headers_installed.stamp" file (which has a dependency on each of the shared .h file and therefore triggers re-installation once any of them changes).

Originally, that was introduced primarily because the NaCl SDK and naclports were using that model. This model allows, for example:

using a "stable" version of a library (the one that is already installed into the SDK) while developing a new version of the library;
deleting the library sources and temporary artifacts after building it once;
protection against accidental inclusion of the library's internal .h file.

None of those benefits really bring much in the context of sub-libraries within our project, and overall this approach causes a bunch of complexity and fragility in the build scripts. Examples of practical problems:

parallel builds might fail due to trying to install the headers simultaneously;
recreating the "env" would result in a stale state with compilation errors that the .h files cannot be found, unless all .stamp files are deleted.

Therefore the suggestion is to get rid of that model, and instead follow a simpler approach that all headers are included directly from the source tree.

This commit disables installation of "public" headers from the //common/cpp library into a common include directory. Instead, the //common/cpp/src directory is simply added into the include search path in needed makefiles. More background on this change is in #132 - to put it simply, this is a pure refactoring that will remove a bunch of compelxity from our build scripts and additionally make migrating them to Emscripten/WebAssembly simpler.

This commit disables installation of "public" headers from the //common/cpp library into a common include directory. Instead, the //common/cpp/src directory is simply added into the include search path in needed makefiles. More background on this change is in #132 - to put it simply, this is a pure refactoring that will remove a bunch of complexity from our build scripts and additionally make migrating them to Emscripten/WebAssembly simpler.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/naclport/common library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/naclport/cpp_client library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/naclport/common library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/naclport/cpp_client library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/naclport/cpp_demo library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //common/integration_testing library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/libusb library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/server library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/server_clients_management library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/libusb library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit disables installation of "public" headers from the //third_party/pcsc-lite/server library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

…#279) This commit disables installation of "public" headers from the //third_party/pcsc-lite/server_clients_management library into a common include directory. Instead, the path to this library is simply added into the include search path in needed makefiles. More background on this refactoring is in #132.

This commit deletes the makefile rules that implement the installation of libraries' headers into the comment include directory. All usages of these rules have been removed by now. Also fix one remaining usage of common installed headers - the //common/integration_testing library - which was incorrectly specifying the include directories. This completes the refactoring tracked by #132.

emaxx-google added enhancement refactoring labels Jun 22, 2020

emaxx-google mentioned this issue Jun 22, 2020

Stop building our libraries separately #133

Closed

emaxx-google mentioned this issue Oct 28, 2020

Stop installing //common/cpp headers #213

Merged

emaxx-google mentioned this issue Nov 9, 2020

Not install pcsc-lite/naclport/common headers #251

Merged

emaxx-google mentioned this issue Nov 9, 2020

Not install pcsc-lite/naclport/cpp_client headers #252

Merged

emaxx-google mentioned this issue Nov 10, 2020

Not install pcsc-lite/naclport/cpp_demo headers #253

Merged

emaxx-google mentioned this issue Nov 13, 2020

Not install //common/integration_testing headers #276

Merged

emaxx-google mentioned this issue Nov 16, 2020

Not install //third_party/libusb headers #277

Merged

emaxx-google mentioned this issue Nov 16, 2020

Not install //third_party/pcsc-lite/server headers #278

Merged

emaxx-google mentioned this issue Nov 16, 2020

Not install //third_party/pcsc-lite/server_clients_management headers #279

Merged

emaxx-google mentioned this issue Nov 16, 2020

Delete header installation scripts #280

Merged

emaxx-google closed this as completed Nov 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop installing headers from our libraries into the common place #132

Stop installing headers from our libraries into the common place #132

emaxx-google commented Jun 22, 2020 •

edited

Loading

Stop installing headers from our libraries into the common place #132

Stop installing headers from our libraries into the common place #132

Comments

emaxx-google commented Jun 22, 2020 • edited Loading

emaxx-google commented Jun 22, 2020 •

edited

Loading