Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResultOrErrorCode should export errorCode #793

Closed
emaxx-google opened this issue Mar 30, 2023 · 0 comments · Fixed by #845
Closed

ResultOrErrorCode should export errorCode #793

emaxx-google opened this issue Mar 30, 2023 · 0 comments · Fixed by #845
Labels
bug

Comments

@emaxx-google
Copy link
Collaborator

The errorCode property of the JavaScript ResultOrErrorCode class is currently not marked as exported. So after the minification, it's not possible to access it directly.

The current workaround is to call getBase() (the opt_onFailed argument is called back with the error code).
emaxx-google added a commit that referenced this issue Jul 25, 2023
@emaxx-google
Expose errorCode in JS API
e1135bb 
JavaScript API library didn't expose the ResultOrErrorCode's error code
value. The "errorCode" property wasn't marked as exported, hence it was
unaccessible after minification.

This commit fixes this by exporting a new "getErrorCode" method instead.
This fixes #793.
@emaxx-google emaxx-google mentioned this issue Jul 25, 2023
Merged
emaxx-google added a commit that referenced this issue Jul 25, 2023
@emaxx-google
Expose errorCode in JS API (#845)
7ed3fa2 
JavaScript API library didn't expose the ResultOrErrorCode's error code
value. The "errorCode" property wasn't marked as exported, hence it was
unaccessible after minification.

This commit fixes this by exporting a new "getErrorCode" method instead.
This fixes #793.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose errorCode in JS API GoogleChromeLabs/chromeos_smart_card_connector
1 participant
@emaxx-google