[chrome-api-jstocxxtest] Add more GetStatusChange tests #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktoriiaKovalova
added this to In progress
in Support for Web Smart Card API
via automation
|
Looks like CI is breaking because of the github bug |
Fabian-Sommer
approved these changes
Sep 4, 2023
| mockControl.$replayAll(); | ||
|
|
||
| launchPcscServer(/*initialDevices=*/[ | ||
| {'id': 123, 'type': 'gemaltoPcTwinReader', 'cardType': 'cosmoId70'} |
There was a problem hiding this comment.
I think considering how often the strings 'gemaltoPcTwinReader' and 'cosmoId70' are used, they deserve to be constants (throughout this file, maybe in another PR) . Especially considering that at least the Gemalto Reader already has some associated constants, and I suspect the exact string might be important.
There was a problem hiding this comment.
good idea! I'll make a follow-up PR :)
|
Continuous Integration: All tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check that events with various
eventStates andeventCounts are handled correctly.Add test with optional timeout parameter passed.