Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chrome-api-jstocxxtest] Move creation of provider to set-up #1036

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[chrome-api-jstocxxtest] Move creation of provider to set-up #1036

merged 2 commits into from
Sep 8, 2023

Conversation

ViktoriiaKovalova
Copy link
Collaborator

Move createChromeApiProvider to set-up.

@ViktoriiaKovalova ViktoriiaKovalova added this to In progress in Support for Web Smart Card API via automation Sep 8, 2023
@ViktoriiaKovalova ViktoriiaKovalova force-pushed the move-chrome-api branch 2 times, most recently from a2dc947 to 17486da Compare September 8, 2023 18:18
@ViktoriiaKovalova ViktoriiaKovalova changed the base branch from get-attrib to main September 8, 2023 18:18
emaxx-google
emaxx-google approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@emaxx-google emaxx-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (seems fine to create it before triggering the PC/SC start, and probably in production we'll have this mode soon as well)

@ViktoriiaKovalova ViktoriiaKovalova changed the base branch from main to await-2 September 8, 2023 20:01
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Continuous Integration: All tests passed.
C/C++ test coverage: 71.76% lines.

Base automatically changed from await-2 to main September 8, 2023 20:33
@emaxx-google emaxx-google merged commit 4e5f76d into main Sep 8, 2023
13 checks passed
Support for Web Smart Card API automation moved this from In progress to Done Sep 8, 2023
@emaxx-google emaxx-google deleted the move-chrome-api branch September 8, 2023 23:09
@ViktoriiaKovalova ViktoriiaKovalova mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaxx-google emaxx-google emaxx-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Support for Web Smart Card API
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ViktoriiaKovalova @emaxx-google