Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome-api-jstocxxtest] Test BeginTransaction #1067

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

ViktoriiaKovalova
Copy link
Collaborator

No description provided.

'onBeginTransactionRequested', /*requestId=*/ 111, readerHandle)
.$waitAndVerify();

// The test `TearDown()` will verify that the disconnection works despite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this copy-pasted comment relevant here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed TearDown to tearDown

Copy link
Collaborator

@emaxx-google emaxx-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

@github-actions
Copy link

Continuous Integration: All tests passed.
C/C++ test coverage: 71.74% lines.

Base automatically changed from transmit to main September 22, 2023 15:08
@github-actions
Copy link

Continuous Integration: All tests passed.
C/C++ test coverage: 71.70% lines.

@ViktoriiaKovalova ViktoriiaKovalova merged commit 5d02d6f into main Sep 22, 2023
10 checks passed
Support for Web Smart Card API automation moved this from In progress to Done Sep 22, 2023
@ViktoriiaKovalova ViktoriiaKovalova deleted the begin-transaction branch September 22, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants