Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick upstream CCID fix for null-deref #850

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

emaxx-google
Copy link
Collaborator

@emaxx-google emaxx-google commented Jul 26, 2023

Cherry-pick the "Check num_altsetting before dereffing altsetting" commit from the CCID Driver repository.

This is supposed to fix the occasional crashes we observe after applying the mitigation from #849.

@github-actions
Copy link

Continuous Integration: All tests passed.
C/C++ test coverage: 71.61% lines.

@github-actions
Copy link

Continuous Integration: All tests passed.
C/C++ test coverage: 71.55% lines.

Copy link
Collaborator

@Fabian-Sommer Fabian-Sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (But watch out, this PR also contains other files right now)

Cherry-pick the "Check num_altsetting before dereffing altsetting"
commit in the CCID Driver repository.

This is supposed to fix the occasional crashes we observe after
applying the mitigation from #849.
@emaxx-google
Copy link
Collaborator Author

LGTM (But watch out, this PR also contains other files right now)

Hrm, chained PRs are handled weirdly by Github. I guess I shouldn't have "merged" PRs until all of them are approved :) Thanks for the review.

@emaxx-google emaxx-google merged commit 8bca311 into main Jul 27, 2023
7 of 8 checks passed
@emaxx-google emaxx-google deleted the ccid-null-deref-cherry-pick branch July 27, 2023 13:33
@github-actions
Copy link

Continuous Integration: All tests passed.
C/C++ test coverage: 71.56% lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants