feat: support userContext is setPermission (#2033)

- keep the prefixed version to maintain compatibility with Puppeteer --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GoogleChromeLabs · Mar 20, 2024 · 3186576 · 3186576
1 parent 08e865b
commit 3186576
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/src/bidiMapper/domains/permissions/PermissionsProcessor.ts b/src/bidiMapper/domains/permissions/PermissionsProcessor.ts
@@ -33,9 +33,9 @@ export class PermissionsProcessor {
     params: Permissions.SetPermissionParameters
   ): Promise<EmptyResult> {
     try {
-      const userContextId = (params as {'goog:userContext'?: string})[
-        'goog:userContext'
-      ];
+      const userContextId =
+        (params as {'goog:userContext'?: string})['goog:userContext'] ||
+        params.userContext;
       await this.#browserCdpClient.sendCommand('Browser.setPermission', {
         origin: params.origin,
         browserContextId:

diff --git a/...er/headful/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini b/...er/headful/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini
diff --git a/...r/headless/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini b/...r/headless/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini
diff --git a/...r/headless/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini b/...r/headless/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini