New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logging #240
Comments
@sadym-chromium please note that I'm currently removing all the |
@whimboo thanks for the heads-up! We'll wait for migration then. |
The sync is going to happen via web-platform-tests/wpt#35513 |
The sync is done and all traces for |
We don't have message caching implemented, so the tests still don't pass on our side. WIP. |
@whimboo another problem is in the fact WPT tests having specific value of the
|
This should actually be related to the discussion on w3c/webdriver-bidi#139. The webdriver tests should most likely check for |
Yes for anything non-primitive, we should use any_string instead of expecting a specific text. Primitive log values should still be asserted as-is I think. |
@sadym-chromium do you want to update the tests yourself as part of your work, or should we do it? |
I'll publish PR with that + removing verification of implementation-defined |
Implemented. |
WPT tests for logging should pass: https://wpt.fyi/results/webdriver/tests/bidi/log?label=master&label=experimental&aligned&q=webdriver&view=subtest
The text was updated successfully, but these errors were encountered: