New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log tests #35577
Update log tests #35577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Would be great to still test objects against any_string, and for the fixture we can simply migrate the current one to bidi.
12667e5
to
97fff2f
Compare
@juliandescottes done, PTAL |
@sadym-chromium as it looks like some tests are failing with Chrome. Even it may be unrelated to your changes maybe you could have a look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, as @whimboo said it would be good to know why there were chrome failures, but looking at the tests that failed I can't really see any relation with this patch?
The logging in Chromium was not implemented correctly. The PR GoogleChromeLabs/chromium-bidi#243 should address it. The problem is the BiDi implementation in ChromeDriver is updated only with ChromeDriver itself, which happens once a month. |
I imagine @whimboo was referring to the CI failures on /webdriver/tests/bidi/browsing_context/navigate/error.py and /webdriver/tests/get_active_element/get.py ? |
Maybe there were some CI issues. Lets retrigger the tests again. |
I guess we can push the change, and fix the navigation tests in ChromeDriverBiDi separately. |
66a81ee
to
80ba4da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine with me. Thanks.
* Remove implementation-defined tests (only text of primitives is defined). * Switch from classic `current_time` to BiDi `current_time_bidi`.
80ba4da
to
3e42e41
Compare
Admin merging to ignore wpt-chrome-dev-stability failure, as requested. |
log.entryAdded
handler in step 5.2 says:current_time
to BiDicurrent_time_bidi
.