feat(script): implement user activation #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/userActivation
branch
from
5ad8455
to
d88b02e
Compare
OrKoN
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
OrKoN
force-pushed
the
orkon/userActivation
branch
from
d88b02e
to
f914661
Compare
thiagowfx
suggested changes
Jul 27, 2023
There was a problem hiding this comment.
Could you also simplify these two tests?
chromium-bidi/tests/test_browsing_context.py
Line 1144 in 4b1945f
chromium-bidi/tests/test_preload_script.py
Line 675 in 4b1945f
See the XXX comment there related to w3c/webdriver-bidi#359.
OrKoN
force-pushed
the
orkon/userActivation
branch
from
f914661
to
7326af3
Compare
OrKoN
force-pushed
the
orkon/userActivation
branch
from
542bc22
to
2e4dc7f
Compare
thiagowfx
reviewed
Jul 27, 2023
thiagowfx
approved these changes
Jul 27, 2023
|
Please watch out for an upcoming merge conflict: #1110 Tests are now organized per domain. |
OrKoN
force-pushed
the
orkon/userActivation
branch
from
2e4dc7f
to
44ca47b
Compare
OrKoN
force-pushed
the
orkon/userActivation
branch
from
44ca47b
to
79967bc
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
Aug 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.20](chromium-bidi-v0.4.19...chromium-bidi-v0.4.20) (2023-08-01) ### Features * implement `browser.close` ([#1116](#1116)) ([a715559](a715559)) * **script:** implement user activation ([#1105](#1105)) ([2408d7f](2408d7f)) ### Bug Fixes * don't publish `.tsbuildinfo` ([#1106](#1106)) ([4b1945f](4b1945f)) * use Result passing to prevent Unhandled promise rejections ([#1112](#1112)) ([e0dc19f](e0dc19f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of tests will be covered by WPT.