Cdp serialization / deserialization #123
Conversation
* Move serialization to CDP-side by using `generateWebDriverValue` in CallFunction, Evaluate and when serialization is needed. * Remove in-realm serialization / deserialization. * Reformatted some files. Not done: * Complete serialization tests. * Deserialization tests.
sadym-chromium
force-pushed
the
cdp_ser
branch
5 times, most recently
from
1fe5532
to
cec2924
Compare
Force WPT using the dev chrome channel
| #initializePageLifecycleEventListener() { | ||
| this.#cdpClient.Page.setLifecycleEventsEnabled({ enabled: true }); | ||
|
|
||
| this.#cdpClient.Page.on('lifecycleEvent', async (params) => { |
There was a problem hiding this comment.
should there be .off calls for every .on call somewhere?
There was a problem hiding this comment.
Let's keep it out of scope of this PR. Ideally, we should subscribe to events only when user subscribed to them, and unsubscribe when user unsubscribed. But for now Mapper (as well as Puppeteer, AFAIK) just listens to all event and sends the needed to user.
| // Primitive Protocol Value | ||
| // https://w3c.github.io/webdriver-bidi/#data-types-protocolValue-primitiveProtocolValue | ||
| case 'undefined': { | ||
| return { unserializableValue: 'undefined' }; |
There was a problem hiding this comment.
what does unserializableValue means? a value that cannot be deserialized?
There was a problem hiding this comment.
Runtime.CallArgument. unserializableValue is basically a string that is evaluated instead of being JSON-deserialized.
|
LGTM in general but I am not very familiar with the bidi spec to see if serialisation is correct. |
We delegate the serialization logic to CDP, but verify it in e2e tests. Deserialization is on the Mapper side, but it is tested by e2e as well. |
Use CDP
generateWebDriverValuefor serialization.The PR happened to be quite huge, as it involved lots of refactoring.
generateWebDriverValuein CallFunction, Evaluate and when serialization is needed.