Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codecov.io coverage for mocha #918

Merged
merged 1 commit into from
Jun 29, 2023
Merged

ci: add codecov.io coverage for mocha #918

merged 1 commit into from
Jun 29, 2023

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx thiagowfx commented Jun 29, 2023

Closes: #17

@thiagowfx thiagowfx force-pushed the thiagowfx/codecov branch 3 times, most recently from ecd7c52 to a19869a Compare June 29, 2023 15:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@85e2add). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7d89cb8 differs from pull request most recent head da943f1. Consider uploading reports for the commit da943f1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage        ?   51.90%           
=======================================
  Files           ?       23           
  Lines           ?      763           
  Branches        ?      150           
=======================================
  Hits            ?      396           
  Misses          ?      341           
  Partials        ?       26           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thiagowfx thiagowfx marked this pull request as ready for review June 29, 2023 15:47
@thiagowfx
Copy link
Contributor Author

@thiagowfx
Copy link
Contributor Author

It's a bit hard to see the effects of this change in a PR. I'll merge it to better test it. Can always revert if needed.

@thiagowfx thiagowfx merged commit 0801561 into main Jun 29, 2023
7 of 11 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/codecov branch June 29, 2023 17:36
@thiagowfx
Copy link
Contributor Author

I think I'll disable comments like this: #920 (comment)

ref. https://docs.codecov.com/docs/pull-request-comments#disable-comment

They seem too noisy

For our purposes, the badge in the README and the codecov.io dashboard seem enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish coverage metrics for each PR
2 participants