Try enforce: 'pre' for istanbul-instrumenter-loader
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 60.77% 53.71% -7.07%
==========================================
Files 54 54
Lines 2904 1670 -1234
==========================================
- Hits 1765 897 -868
+ Misses 1139 773 -366
Continue to review full report at Codecov.
|
This was referenced May 15, 2019
foolip
added a commit
that referenced
this pull request
May 15, 2019
Currently instrumentation is running after babel, which results in incorrect and nonsensical coverage information. The node vs. web coverage here is an example: https://codecov.io/gh/GoogleChromeLabs/confluence/src/f6802df5a6be89042a1db1e7b82f0a0a90906caf/lib/dao/indexed_dao.es6.js This could be fixed by changing the order: #404 However, it's not clear if that's correct: webpack-contrib/istanbul-instrumenter-loader#86 There's no need to run Babel to test stable versions of Chrome or Firefox, so just skip babel-loader.
|
This was an experiment for #398. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack-contrib/istanbul-instrumenter-loader#86 (comment)