fix: support legal comments (#143)

GoogleChromeLabs · Mar 5, 2024 · 8494a53 · 8494a53
1 parent 03ca6b5
commit 8494a53
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/packages/critters/src/index.js b/packages/critters/src/index.js
@@ -14,17 +14,17 @@
  * the License.
  */
 
-import path from 'path';
 import { readFile } from 'fs';
 import { createDocument, serializeDocument } from './dom';
+import path from 'path';
 import {
+  applyMarkedSelectors,
+  markOnly,
   parseStylesheet,
   serializeStylesheet,
+  validateMediaQuery,
   walkStyleRules,
   walkStyleRulesWithReverseMirror,
-  markOnly,
-  applyMarkedSelectors,
-  validateMediaQuery
 } from './css';
 import { createLogger, isSubpath } from './util';
 
@@ -495,10 +495,12 @@ export default class Critters {
       ast,
       markOnly((rule) => {
         if (rule.type === 'comment') {
-          const comment = rule.text.trim();
+          // we might want to remove a leading ! on comment blocks
+          // critters can be part of "legal comments" which aren't striped on build
+          const crittersComment = rule.text.match(/^(?<!\! )critters:(.*)/);
+          const command = crittersComment && crittersComment[1];
 
-          if (comment.startsWith('critters')) {
-            const command = comment.replace(/^critters:/, '');
+          if (command) {
             switch (command) {
               case 'include':
                 includeNext = true;

diff --git a/packages/critters/test/src/styles.css b/packages/critters/test/src/styles.css
@@ -46,6 +46,12 @@ footer {
   border-bottom: transparent solid 2px;
 }
 
+/*! critters:include */
+.other-element::part(tab) {
+  color: #0c0dcc;
+  border-bottom: transparent solid 2px;
+}
+
 .custom-element::part(tab):hover {
   background-color: #0c0d19;
   color: #ffffff;
@@ -64,7 +70,6 @@ footer {
 }
 /* critters:include end */
 
-
 .custom-element::part(active) {
   color: #0060df;
   border-color: #0a84ff !important;