Create an explicit ~/.jsvu/bin path
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we asked users to add `~/.jsvu` to their `$PATH`, which meant that `status.json` and `engines` also became exposed (and autocompleted, etc.). This patch moves the binaries and wrapper scripts to a dedicated `~/.jsvu/bin` directory containing nothing else. This is a breaking change; jsvu users have to update their `$PATH` replacing `$HOME/.jsvu` with `$HOME/.jsvu/bin`. Issue: #116
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Dec 24, 2022
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Dec 25, 2022
|
@mathiasbynens - This change appears to have caused an issue with the v8 engine on Windows: #130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we asked users to add
~/.jsvuto their$PATH, which meant thatstatus.jsonandenginesalso became exposed (and autocompleted, etc.).This patch moves the binaries and wrapper scripts to a dedicated
~/.jsvu/bindirectory containing nothing else.This is a breaking change; jsvu users have to update their
$PATHreplacing$HOME/.jsvuwith$HOME/.jsvu/bin.Issue: #116