Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

How long does it take for the bot to accept the collaborator request? #55

Closed
cbillowes opened this issue Feb 19, 2019 · 20 comments
Closed

Comments

@cbillowes
Copy link

I added lighthousebot as a collaborator and I have bee waiting for a response for close to 12 hours. How long does it take for the bot to accept the request? I would have thought it to be instant. Is this a manual process? Am I missing a step somewhere?

I went to settings > collaborators > entered the bot name and clicked on add collaborator.

@Toolo
Copy link

Toolo commented Feb 19, 2019

Waiting for it to accept, too. I was expecting it to be automatic; if there's any process involved I'd be happy to create pull to update the README.md stating so 😃

@curiouscrusher
Copy link

I've been waiting for multiple collab requests for almost 2 weeks now, it'd be great to have some clarity on what the timeline/requirements is for collaboration requests to be accepted.

@hammerhernandez
Copy link

I have the same issue and I need to use it ASAP. 👍

Can someone of Lighthouse explain it.

Best Regards, @ebidel 💯

@bzitzow
Copy link

bzitzow commented May 25, 2019

+1
We are also waiting for lighthousebot to accept the request since May 5th.
That's 20 days.
We just removed and added again but still waiting.

image (5)

@ebidel
Copy link
Contributor

ebidel commented May 26, 2019

@addyosmani is someone looking after this?

@addyosmani
Copy link
Contributor

@khempenius I'm trying to locate the Lighthousebot requests but don't seem to have had notifications about them. Have you received any?

@khempenius
Copy link

@addyosmani I have not received any requests.

@hammerhernandez
Copy link

Hi Guys,

Any resolution about it? Or something that we can do or help?

Best Regards, @ebidel @addyosmani @khempenius

@sumit-gupta91
Copy link

I added lighthousebot as a collaborator and I have bee waiting for a response for close to 12 hours. How long does it take for the bot to accept the request? @ebidel @addyosmani

@ebidel
Copy link
Contributor

ebidel commented May 31, 2019 via email

@bzitzow
Copy link

bzitzow commented Jun 1, 2019

@ebidel @addyosmani We are excited to have lighthouse checks as part of our CI pipeline. Getting the lighthousebot collaborator is the last step.

Any ideas on how we can reach out to "someone at google" so they can help get these requests approved?

@sumit-gupta91
Copy link

@ebidel Hi, yes I did receive an email as an API key, but lighthouse bot has yes been added as a collaborator it is waiting for a response from lighthouse bot.

@rayriffy
Copy link

rayriffy commented Jun 3, 2019

+1

@ebidel
Copy link
Contributor

ebidel commented Jun 3, 2019

Ok. Someone with credential access to the lighthouse bot account will need to approve the requests coming in. Unfortunately, I'm not sure got that completely figured out after I left the team. We were working with GH support to verify @addyosmani and @khempenius 's emails for the account.

@addyosmani
Copy link
Contributor

@ebidel When you get a chance, could you share (email) where you were getting these approval requests sent through to? Unfortunately even with access to the lighthousebot GH account, we're still not receiving these requests.

Folks: Katie and I discussed it. If we're unable to get Lighthousebot sorted in the coming weeks, we're going to accelerate getting together working examples of LightWallet (official perf budgeting in Lighthouse) working in CI and a codelab so you can still get the perf budgeting portion of this workflow at least.

@addyosmani
Copy link
Contributor

Can someone try sending through new collaborator requests again so we can test this works now? :)

@khempenius I've gone ahead and:

  1. Created a new email address for Lighthousebot notifications (lighthousebotofficial at gmail, you should have access)
  2. Added this as the primary account notification email for lighthousebot
  3. Verified email notifications should be coming through correctly here now

Although I have no way of receiving old lighthousebot approval requests, we should now be able to receive them for any new users. Keeping fingers crossed at least...

@sumit-gupta91
Copy link

Sending a new request right away

@addyosmani
Copy link
Contributor

I've approved 7 requests that came through last night. Feel free to keep them coming. I've confirmed with at least one user everything is working as expected now.

To close this bug report up: the collaborator request currently requires manual approval. Katie and I will do our best to process these every few days. As we work on more official CI solutions, we'll be looking at how to automate everything to drastically reduce time between requests and approvals.

@sumit-gupta91
Copy link

Thanks @addyosmani, lighthousebot is now added as a collaborator.

@curiouscrusher
Copy link

Big thanks to @addyosmani & @ebidel for getting this sorted out!
I just sent in several collab requests so hopefully we'll be able to get this slotted into our CI Pipeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants