Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'node_modules/native-url/third_party/url.d.ts' is not a module. #34

Open
thishussein opened this issue Mar 8, 2021 · 2 comments · May be fixed by #35
Open

'node_modules/native-url/third_party/url.d.ts' is not a module. #34

thishussein opened this issue Mar 8, 2021 · 2 comments · May be fixed by #35

Comments

@thishussein
Copy link

Expected Behavior

I expected TypeScript to not complain since there are built-in declarations

Actual Behavior

TypeScript throws an error

main.ts:1:17 - error TS2306: File 'G:/experiments/node_modules/native-url/third_party/url.d.ts' is not a module.

1 import url from "native-url";

image

Steps to Reproduce the Problem

  1. Create a TypeScript project with both '@types/node' and 'native-url' installed
  2. Try to compile it

tsconfig.json:

{
  "compilerOptions": {
    "strict": true
  }
}

Specifications

  • Version: Node v14.15.1
  • Platform: Windows 10
thishussein added a commit to thishussein/native-url that referenced this issue Mar 8, 2021
@thishussein thishussein linked a pull request Mar 8, 2021 that will close this issue
2 tasks
@ScriptedAlchemy
Copy link

Can we get some movement on this fix?

mochaaP added a commit to mochaaP/native-url that referenced this issue Aug 22, 2021
Singed-off-by: Hussein <huseeiin@outlook.com>
mochaaP added a commit to mochaaP/native-url that referenced this issue Aug 22, 2021
Signed-off-by: Hussein <huseeiin@outlook.com>
@niksy
Copy link

niksy commented Sep 28, 2021

What can we help with to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants