Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

No feedback on SyntaxError #95

Closed
romgrk opened this issue Aug 2, 2018 · 12 comments
Closed

No feedback on SyntaxError #95

romgrk opened this issue Aug 2, 2018 · 12 comments

Comments

@romgrk
Copy link

romgrk commented Aug 2, 2018

Steps to reproduce

Tell us about your environment:

  • ndb version: 1.0.18
  • Platform / OS version: ubuntu 17.04
  • Node.js version: 8.9.4

What steps will reproduce the problem?

// File: test.js
test()
function test() {
 debugger {
}
  1. ndb test.js

What is the expected result?
Some feedback that there is a syntax error

What happens instead?
No feedback, nothing happens

@alexkozy
Copy link
Contributor

alexkozy commented Aug 3, 2018

Thanks for your report!
Do you have message like this in console? Would you like to get warning somewhere else in UI?
image

@romgrk
Copy link
Author

romgrk commented Aug 3, 2018

No, that's the problem, I don't even get a message in the console, which would be fine.
If you need me to provide additional details for debugging just send me the instructions.

@romgrk
Copy link
Author

romgrk commented Aug 3, 2018

Ok, something weird just happened. I tried to reproduce the issue on my home laptop (archlinux, node 10), and got the same result using the 1.0.18 version from npm.
Then, I installed ndb directly from this repository, tried it, and got a message in the console.
Then, I tried again with the npm version and got a message as well.

Not sure what happened, but I'll check if I can reproduce with my work setup (on monday).

@alexkozy
Copy link
Contributor

alexkozy commented Aug 7, 2018

Thanks for your report, I will close it for now. Feel free to reopen it if it still reproducible on your machine at work.

@alexkozy alexkozy closed this as completed Aug 7, 2018
@romgrk
Copy link
Author

romgrk commented Aug 7, 2018

Still able to reproduce (with the same file as above):

screenshot from 2018-08-07 15-11-37

(Unable to reopen the issue, can only see the comment button)

@alexkozy alexkozy reopened this Aug 7, 2018
@alexkozy
Copy link
Contributor

alexkozy commented Aug 7, 2018

Thanks, could you tell what terminal do you use? Based on screenshot it does not look like regular bash :)

@romgrk
Copy link
Author

romgrk commented Aug 7, 2018

Shell: zsh 5.2 (x86_64-ubuntu-linux-gnu)
Terminal: GNOME Terminal 3.24.2 Using VTE version 0.48.4 +GNUTLS -PCRE2

I get the same issue using regular bash:
screenshot from 2018-08-07 15-25-35

@alexkozy
Copy link
Contributor

alexkozy commented Aug 7, 2018

Thanks! Couple more questions: could you open DevTools on ndb by pressing Ctrl + Shift + I and copy paste console output here if there anything and update to latest ndb version 1.0.20 and verify that it is still reproducible?

@romgrk
Copy link
Author

romgrk commented Aug 7, 2018

ndb 1.0.18 console:
screenshot from 2018-08-07 16-32-44

ndb 1.0.20:
screenshot from 2018-08-07 16-34-10

@alexkozy
Copy link
Contributor

alexkozy commented Aug 7, 2018

Thanks! I finally can reproduce it locally and am working on fix.

@alexkozy
Copy link
Contributor

alexkozy commented Aug 8, 2018

It looks to me that the root of the issue is combination of "Pause on exception" toggle, "Blackbox anything outside working directory" checkbox from Settings and Node 8.

You can disable "Pause on exception" to get SyntaxError in console.
You can disable "Blackbox anything outside working directory" to get pause inside internal vm.js script.
You can update your node to 10 to get SyntaxError in console even when both features are enabled.

alexkozy added a commit that referenced this issue Aug 8, 2018
)

- latest DevTools frontend contains automapping fix,
- backend fs fix fetching content of small files.

Helps with #95
@alexkozy
Copy link
Contributor

Unfortunately it is too late to fix Node 8, please use Node 10 if it is possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants