Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventListener options (capture, passive, once) #14

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DougAnderson444
Copy link

Ref: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters

Great library! For my use case, I also needed to capture the event, but this option wasn't available... until now. I threw in passive and once for good measure, but really I was after capture.

I added the capture option to my fork, simple change which seems to work well. I present this pull request as a token of my appreciation for making this library in the first place.

Thanks :)

@google-cla
Copy link

google-cla bot commented Apr 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@DougAnderson444
Copy link
Author

Hello,

The CLA is complete for this pull request to add the capture option to this library.

Can someone please review it?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant