Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Adding "searchByChunkId" option #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michellocana
Copy link

As i commented in #91, the plugin currently checks only chunk.name when using include option, this pull request make possible to search by chunk id, so we can preload chunks named by webpack's NamedChunksPlugin

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@michellocana
Copy link
Author

@jeffposnick i signed the CLA for my github account, do i need to do something else

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants