Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace table with div for better flexibility #157

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Replace table with div for better flexibility #157

merged 7 commits into from
Sep 28, 2023

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Sep 26, 2023 •
edited by mohdsayed

Description

This PR includes code to replace table tag with div for providing better resizing UX. Alongside changes bit of resizing logic.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Related: #154

@mayan-000 mayan-000 marked this pull request as ready for review September 28, 2023 05:18
mohdsayed
mohdsayed approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohdsayed mohdsayed merged commit cc51195 into develop Sep 28, 2023
4 checks passed
@mohdsayed mohdsayed deleted the ref/table branch September 28, 2023 16:31
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@ayushnirwal ayushnirwal Awaiting requested review from ayushnirwal

@amedina amedina Awaiting requested review from amedina

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayan-000 @mohdsayed