Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GSI messaging on correct urls. #684

Merged
merged 5 commits into from
May 30, 2024
Merged

Fix: GSI messaging on correct urls. #684

merged 5 commits into from
May 30, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented May 20, 2024

Description

Sometimes when the site is reloaded quickly then the GSI shows error saying we are on invalid URL. This PR aims to fix that.

Relevant Technical Choices

Testing Instructions

  • Clone this branch and in terminal run npm start.
  • Open a fresh browser instance.
  • Go to linkedin.com
  • Open PSAT.
  • Now click on reload button twice (Start a reload cancel the reload and then start again).
  • GSI section should not show invalid URL message.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #681

@amovar18 amovar18 self-assigned this May 20, 2024
@amovar18 amovar18 marked this pull request as ready for review May 28, 2024 10:09
@amovar18 amovar18 requested a review from mohdsayed May 28, 2024 10:10
@mohdsayed mohdsayed added this to the v1.0.0 milestone May 30, 2024
@mohdsayed mohdsayed added the bug Something isn't working label May 30, 2024
@mohdsayed mohdsayed merged commit 86cf294 into develop May 30, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/draft-issues branch May 30, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants