Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm still installs V2 #99

Closed
ghost opened this issue Sep 10, 2019 · 7 comments
Closed

npm still installs V2 #99

ghost opened this issue Sep 10, 2019 · 7 comments

Comments

@ghost
Copy link

ghost commented Sep 10, 2019

#97 #98
I'm assuming because the package version has been at 3.1.0 since 2c24a60 (Jan 22, 2018), npm is still installing code using the V2 PageSpeed Insights API. Given that the package has been updated to use V4 and now V5 of the API, can the version of this package be updated and published to npm?

@exterkamp
Copy link
Collaborator

Hm, yup need to make a new release. Good call.

@jjmoorhouse
Copy link

would be pretty handy if you could push the latest version to npm....

@exterkamp
Copy link
Collaborator

Haha, yup, I just need to pester the right people to get access to do it or have them do it @addyosmani / @paulirish!

@addyosmani
Copy link
Collaborator

@exterkamp you should be all set now! https://www.npmjs.com/package/psi

@ftanrisevdi
Copy link

I wonder when we can use the 4.0.0 version, npm is still 3.1.0?

@exterkamp
Copy link
Collaborator

This is purely because I am behind 😭

We'll land #104 then release a 4.0.1 to npm.

@exterkamp
Copy link
Collaborator

Updated! Sorry this took so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants