Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use name instead of short_name for meta tags when latter is not available #169

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Use name instead of short_name for meta tags when latter is not available #169

merged 1 commit into from
Jun 11, 2019

Conversation

westonruter
Copy link
Collaborator

Fixes #168.

Prevents undefined index PHP warning.

felixarntz
felixarntz approved these changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonruter westonruter merged commit 8fbaf8b into master Jun 11, 2019
@westonruter westonruter deleted the fix/undefined-index-short-name branch June 11, 2019 18:09
@westonruter westonruter added this to the 0.3 milestone Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Undefined index: short_name
2 participants
@westonruter @felixarntz