Replace WP_DEBUG with more appropriate flags #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
remove/wp-debug
branch
from
8686f59
to
5d226a0
Compare
felixarntz
requested changes
Jan 28, 2020
| $script = file_get_contents( PWA_PLUGIN_DIR . '/' . $workbox_dir . 'workbox-sw.js' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents | ||
| $script = preg_replace( '://# sourceMappingURL=.+?\.map:', '', $script ); | ||
| $script .= file_get_contents( PWA_PLUGIN_DIR . '/' . $workbox_dir . 'workbox-sw.js' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents | ||
| $script .= preg_replace( '://# sourceMappingURL=.+?\.map:', '', $script ); |
There was a problem hiding this comment.
This probably shouldn't be appended - likely an oversight :)
There was a problem hiding this comment.
Good catch. Fixed in 22605b4.
| $enable_debug_log = defined( 'WP_SERVICE_WORKER_DEBUG_LOG' ) && WP_SERVICE_WORKER_DEBUG_LOG; | ||
| if ( ! $enable_debug_log ) { | ||
| $script .= "self.__WB_DISABLE_DEV_LOGS = true;\n"; | ||
| } |
|
That approach sounds good to me, thanks! |
felixarntz
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170.
SCRIPT_DEBUGto indicate that non-production sources of Workbox should be used.PWA_VERSIONinstead ofWP_DEBUGto determine if it is a dev version of the plugin.By default the Workbox dev logs are disabled. To enable them, define this constant in the
wp-config.php:This only has any effect when
SCRIPT_DEBUGis also enabled, as it causes the Workbox dev scripts to be used. When constant is present, the service worker will have the__WB_DISABLE_DEV_LOGSvariable set which causes Workbox to not output the noisy logging messages. For more on that, GoogleChrome/workbox#1619 (comment).