Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate auto-derived short_name from manifest since not reliable #201

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Eliminate auto-derived short_name from manifest since not reliable #201

merged 2 commits into from
Jul 29, 2019

Conversation

westonruter
Copy link
Collaborator

Fixes #181.
Closes #200.
Related #168.

Also improves robustness of \Test_WP_HTTPS_UI::test_filter_site_url_and_home() to account for case where WP_HOME is set, and to ensure site_url() and home_url() are both accounted for.

@westonruter westonruter added this to the 0.3 milestone Jul 29, 2019
@westonruter westonruter requested a review from amedina July 29, 2019 00:03
@westonruter westonruter mentioned this pull request Jul 29, 2019
Closed
amedina
amedina approved these changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@westonruter westonruter merged commit 7d7b8f3 into master Jul 29, 2019
@westonruter westonruter deleted the remove/manifest-short-name branch July 29, 2019 00:42
This was referenced Aug 7, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Short Name empty Remove heuristic for auto-generating short_name from site title
2 participants
@westonruter @amedina