Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording of the serverOffline message. #314

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

KZeni
Copy link
Contributor

@KZeni KZeni commented Jul 22, 2020

The serverOffline message was being shown even though the site was online & working perfectly fine while it was an issue with the client's connection (while they weren't necessarily considered offline.) As such, it should mention both possibilities so people don't instantly blame the website when that might not be the cause for the issue.

… the site was online & working perfectly fine while it was an issue with the client's connection (while they weren't necessarily considered offline.)
@westonruter
Copy link
Collaborator

Thanks for.the PR. We tried to detect whether the user was offline in #190 and serve a clientOffline message in that case. Nevertheless, navigator.onLine is limited in it's effectiveness, such as to handle Lie-Fi scenarios. Is this what you experienced?

@KZeni
Copy link
Contributor Author

KZeni commented Jul 22, 2020

I can't say for certain. I was forwarded a screenshot from a client where it was giving this message even though the site was verifiably still online & working properly for others.

@westonruter
Copy link
Collaborator

Were they able to access other websites successfully? Just wondering if we can also improve the Lie-Fi detection.

Can you inquire if they were trying to access the site and the request took a long time until finally it failed? One thing I want to explore is make use of service worker timeouts to short-circuit requests in these cases.

At the very least, it's true that the current onLine detection is not robust so your change makes sense.

@westonruter westonruter added this to the 0.6 milestone Jul 22, 2020
@westonruter westonruter merged commit b02eb65 into GoogleChromeLabs:develop Jul 22, 2020
@KZeni
Copy link
Contributor Author

KZeni commented Jul 22, 2020

It appears they were having issues with other sites, based on their screenshot. I'll let you know if I hear any further details back.

Thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants