Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all classes final since not intended to be extended #360

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

westonruter
Copy link
Collaborator

Fixes #340

@westonruter westonruter added this to the 0.6 milestone Dec 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #360 (550fdb9) into develop (17e23ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #360   +/-   ##
==========================================
  Coverage      25.54%   25.54%           
  Complexity       362      362           
==========================================
  Files             54       54           
  Lines           1785     1785           
==========================================
  Hits             456      456           
  Misses          1329     1329           
Flag Coverage Δ Complexity Δ
php 25.54% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ass-wp-service-worker-admin-assets-integration.php 0.00% <ø> (ø) 15.00 <0.00> (ø)
...p-service-worker-custom-background-integration.php 0.00% <ø> (ø) 5.00 <0.00> (ø)
...ss-wp-service-worker-custom-header-integration.php 0.00% <ø> (ø) 16.00 <0.00> (ø)
...lass-wp-service-worker-custom-logo-integration.php 0.00% <ø> (ø) 7.00 <0.00> (ø)
...ions/class-wp-service-worker-fonts-integration.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
...ns/class-wp-service-worker-scripts-integration.php 0.00% <ø> (ø) 21.00 <0.00> (ø)
.../class-wp-service-worker-site-icon-integration.php 0.00% <ø> (ø) 6.00 <0.00> (ø)
...ons/class-wp-service-worker-styles-integration.php 0.00% <ø> (ø) 21.00 <0.00> (ø)
wp-includes/class-wp-https-detection.php 85.00% <ø> (ø) 29.00 <0.00> (ø)
wp-includes/class-wp-https-ui.php 83.15% <ø> (ø) 37.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e23ef...550fdb9. Read the comment docs.

Copy link
Collaborator

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@westonruter westonruter merged commit 4454283 into develop Dec 14, 2020
@westonruter westonruter deleted the update/class-finality branch December 14, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make classes final
3 participants