Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wp_register_service_worker_caching_route() to reflect change to underlying register method #424

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

westonruter
Copy link
Collaborator

This rectifies something that I missed in #338.

@westonruter westonruter added this to the 0.7 milestone Feb 15, 2021
@codecov-io
Copy link

Codecov Report

Merging #424 (2201897) into develop (a16e493) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #424   +/-   ##
==========================================
  Coverage      24.19%   24.19%           
  Complexity       364      364           
==========================================
  Files             55       55           
  Lines           1872     1872           
==========================================
  Hits             453      453           
  Misses          1419     1419           
Flag Coverage Δ Complexity Δ
php 24.19% <0.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ponents/class-wp-service-worker-caching-routes.php 72.26% <ø> (ø) 39.00 <0.00> (ø)
wp-includes/service-workers.php 21.15% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16e493...2201897. Read the comment docs.

@westonruter westonruter force-pushed the update/global-function-register-caching-route branch from 2201897 to fb6f74b Compare July 7, 2021 00:23
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #424 (fb6f74b) into develop (cb40420) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #424   +/-   ##
==========================================
  Coverage      23.25%   23.25%           
  Complexity       364      364           
==========================================
  Files             56       56           
  Lines           1948     1948           
==========================================
  Hits             453      453           
  Misses          1495     1495           
Flag Coverage Δ
php 23.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/class-wp-service-worker-caching-routes.php 72.26% <ø> (ø)
wp-includes/service-workers.php 21.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb40420...fb6f74b. Read the comment docs.

@westonruter westonruter force-pushed the update/global-function-register-caching-route branch from 7e6c30e to 968872f Compare July 7, 2021 00:35
@westonruter westonruter merged commit a448a6a into develop Jul 7, 2021
@westonruter westonruter deleted the update/global-function-register-caching-route branch July 7, 2021 00:38
@westonruter westonruter added this to Ready for QA in Ongoing Feb 10, 2022
@pooja-muchandikar
Copy link

QA Passed ✅

On registering new plugin with following code was able to register service worker caching route.

Screenshot 2022-04-20 at 4 33 22 PM


Screenshot 2022-04-20 at 4 30 34 PM


Screenshot 2022-04-20 at 4 34 29 PM


@maitreyie-chavan maitreyie-chavan moved this from Ready for QA to QA Passed in Ongoing Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ongoing
  
QA Passed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants