Avoid auto-reload on offline/500 template if page called directly for development #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user open page from /?wp_error_template=offline, do not reload the page
Codecov Report
@@ Coverage Diff @@
## develop #716 +/- ##
==========================================
Coverage 19.96% 19.96%
Complexity 326 326
==========================================
Files 56 56
Lines 2094 2094
==========================================
Hits 418 418
Misses 1676 1676
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@westonruter This PR is ready for your review, I have added the changes as you asked in #697 (comment) |
westonruter
approved these changes
Mar 1, 2022
westonruter
changed the title
|
QA Passed ✅ The changes are working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user open page from
/?wp_error_template=offline, do not reload the pageSee #697 (comment)