Add support for same-site prerendering with Speculation Rules API #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
…es API limitations and ease of change once the limitations are updated
…google formatting
domenic
reviewed
Aug 1, 2022
Co-authored-by: Domenic Denicola <d@domenic.me>
addyosmani
reviewed
Aug 1, 2022
addyosmani
reviewed
Aug 1, 2022
removed extra argument in the promise constructor fixed the inconsistent application of spacing throughout repo
…into speculationrules
domenic
reviewed
Aug 2, 2022
| if (/2g/.test(conn.effectiveType)) { | ||
| return Promise.reject(new Error('Cannot prefetch, network conditions are poor')); | ||
| } | ||
| let chkConn = checkConnection(conn = navigator.connection); |
There was a problem hiding this comment.
It's not clear why this is assigning to the conn parameter. Did you mean to set a default on line 201? Or just remove the conn parameter altogether? Or do conn || navigator.connection?
I guess this was already buggy...
| * @return {Object} a Promise | ||
| */ | ||
| export function prerender(urls, conn) { | ||
| let chkConn = checkConnection(conn = navigator.connection); |
There was a problem hiding this comment.
Same problem with assigning to a parameter here.
Co-authored-by: Domenic Denicola <d@domenic.me>
Co-authored-by: Domenic Denicola <d@domenic.me>
Co-authored-by: Domenic Denicola <d@domenic.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253