Bugfix/clean up

[anton-karlovskiy]

README is updated (minor).

[addyosmani]

I intentionally excluded the other supported values here as they were making the code-snippet look a little on the long side (I imagine most users would use 2 values) 😄

That said, perhaps a good middle ground is a line after each code-snippet that notes the supported return values? e.g 2g, 3g etc. Wdyt?

[anton-karlovskiy]

I got you.

So for Network, Save Data, CPU Cores / Hardware Concurrency, Memory, after code snippet, we can add some line that notes the supported return values.

For example for Network, effectiveConnectionType values can be slow-2g, 2g, 3g, and 4g.

Am I correct?

[anton-karlovskiy]

  switch (effectiveType) {
    case '3g':
      module = import(/* webpackChunkName: "light" */ './Light.js');
      break;
    case '4g':
      module = import(/* webpackChunkName: "full" */ './Full.js');
      break;
    default:
      module = import(/* webpackChunkName: "full" */ './Full.js');
      break;
  }

I thought that if effective connection type is 2g, the user might end up downloading Full.js.

[addyosmani]

For example for Network, effectiveConnectionType values can be slow-2g, 2g, 3g, and 4g.

Yes, exactly!

[addyosmani]

LGTM with minor comments.

[addyosmani]

@anton-karlovskiy This should be good to land soon. Would you like to go ahead with making those minor changes discussed in the comments?

[anton-karlovskiy]

@anton-karlovskiy This should be good to land soon. Would you like to go ahead with making those minor changes discussed in the comments?

Yes, it's done. Could you please review it?

[addyosmani]

LGTM