Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constant hook #5

Closed
wants to merge 1 commit into from
Closed

Conversation

jeetiss
Copy link

@jeetiss jeetiss commented Nov 12, 2019

useConstant is better way to use constants as a hook)

it's run ones, don't have invalidation and don't create logic for update value, it's size just 223B

I added use-constant as deps.
Do you think will be better move it to repo?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jeetiss jeetiss changed the title se constant hook use constant hook Nov 12, 2019
@jeetiss
Copy link
Author

jeetiss commented Nov 12, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@alireza-mh
Copy link

Is this do the same thing as #1 ?

@jeetiss
Copy link
Author

jeetiss commented Nov 12, 2019

@alireza-mh yes

@koester
Copy link

koester commented Nov 12, 2019

I think #1 should be preferred over this solution. There is no need to add a dependency for this.

@addyosmani
Copy link
Collaborator

Thank you for proposing this change, @jeetiss. Appreciate it! I've chosen to opt for #1 which we just landed in favor of introducing the dependency for now. Cheers!

@addyosmani addyosmani closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants