Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved glob pattern matching. #37

Merged
merged 2 commits into from Feb 23, 2018
Merged

Conversation

ncruces
Copy link
Contributor

@ncruces ncruces commented Feb 7, 2018

As discussed in #36.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ncruces
Copy link
Contributor Author

ncruces commented Feb 7, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

return err
}
case '!':
if err := c.compileSubExpression("(?~", ")", "\\!"); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative matches are not actually supported. Go regexp supports neither negative lookahead (?!), nor the Ruby's absence operator (?~) that we'd need to implement this. This returns an ErrInvalidPerlOp.

@@ -33,7 +33,7 @@ type FirebaseManifest struct {

func (mf FirebaseManifest) processRedirects(w http.ResponseWriter, r *http.Request) (bool, error) {
for _, redirect := range mf.Redirects {
pattern, err := CompileExtGlob(redirect.Source)
pattern, err := CompileExtGlob("/" + strings.TrimPrefix(redirect.Source, "/"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be compatible with Firebase, patterns should start with a /, and be matched against r.URL.Path (which also starts with a /).

@surma
Copy link
Contributor

surma commented Feb 23, 2018

10/10 for the test suite! That gives me a lot of confidence. Well done.

@surma surma merged commit 0118534 into GoogleChromeLabs:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants