Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When JS is disabled no message is displayed #593

Closed
lucacasonato opened this issue May 18, 2019 · 1 comment · Fixed by #1362
Closed

When JS is disabled no message is displayed #593

lucacasonato opened this issue May 18, 2019 · 1 comment · Fixed by #1362
Labels
good first issue Good for newcomers help wanted Extra attention is needed UI UI related issues

Comments

@lucacasonato
Copy link

lucacasonato commented May 18, 2019 •
edited

Describe the bug
When opening the page in any browser and disabling JS, the page does not react. It just displays everything like normal but does not respond to any clicks (obviously).

To Reproduce
Steps to reproduce the behavior:

  1. Go to squoosh
  2. Disable JS
  3. Reload page

Expected behavior
Display a message or screen that JS is needed to use Squoosh.

Version:

  • OS w/ version: any
  • Browser w/ version any
  • Node version: n/a
  • npm version: n/a
@kosamari kosamari added help wanted Extra attention is needed UI UI related issues good first issue Good for newcomers labels Jul 1, 2021
@kosamari
Copy link
Contributor

kosamari commented Jul 1, 2021

probably render message on the same position as error dialogue

TimvdLippe added a commit to TimvdLippe/squoosh that referenced this issue Oct 21, 2021
@TimvdLippe
Add message for users that disabled JavaScript
1496057 
Fixes GoogleChromeLabs#593
@TimvdLippe TimvdLippe mentioned this issue Oct 21, 2021
Closed
@Elessar1802 Elessar1802 mentioned this issue Mar 16, 2023
Closed
@tsukinoko-kun tsukinoko-kun mentioned this issue Apr 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed UI UI related issues
Projects
None yet
Milestone
No milestone
2 participants
@kosamari @lucacasonato