This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Explicitly set redirect: follow on the precaching requests.
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2017
|
Sorry got lost on the repo I was on - LGTM from me. |
WillMoggridge
added a commit
to WillMoggridge/tutorials.ubuntu.com
that referenced
this pull request
Jan 17, 2017
This installs polymer-cli and related tools in the local folder. It uses npm shrinkwrap to upgrade sub dependency for sw-precache. This is to prevent an issue in Firefox which has been fixed upstream with: GoogleChromeLabs/sw-precache#233
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
The default mode for
redirectis'follow', as per the Fetch API specification.However, as per #220, that default behavior doesn't appear to be universally applied, in particular in older versions of Chrome and in more recent versions of Firefox.
This PR changes precaching requests to explicitly set
redirect: 'follow'to ensure that the behavior is consistent instead of relying on the browser default. Since that was what I had expected the behavior to be already (in browsers following the spec), I think this should be a "safe" change, and will roll it out with an accompanying minor version bump.Fixes #220