Switch to wabt.js #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's somewhat easier to use from JavaScript, makes wabt a regular npm dependency, and, what's even more important, is more frequently updated than WABT pre-built binaries. It's not yet updated to fix #22 for us, but should be on the next nightly build - feel free to either merge this now or keep open until it gets updated.
surma
approved these changes
May 5, 2020
RReverser
added a commit
that referenced
this pull request
May 12, 2020
Back in #23 I've updated README.md manually as I forgot it's generated from README.md.ejs. Updating the source too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's somewhat easier to use from JavaScript, makes wabt a regular npm dependency, and, what's even more important, is more frequently updated than WABT pre-built binaries.
It's not yet updated to fix #22 for us, but should be on the next nightly build - feel free to either merge this now or keep open until it gets updated.