-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite bundling for smaller bundles #3
Conversation
f5fc763
to
2ea6e36
Compare
So I like where this is going, thanks for your effort! Two things:
An idea I’ve had (and maybe you wanna take a stab at that): I wondered if hex encoding is better.
WDYT? |
058c739
to
ddac08e
Compare
@surma what are you using to test the gzipped size. by my count we are now saving exactly 1 byte, but we also no longer rely on fetch. |
8cd34d3
to
0158149
Compare
|
0158149
to
eeac074
Compare
in that case we're now down to 587 |
Brilliant! Thanks a bunch! I’m on mobile for today, but I’ll give this a proper review tomorrow 🎉 |
da6cd09
to
a7faa45
Compare
a7faa45
to
29d97ec
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
7822ec5
to
44ea18a
Compare
@@ -0,0 +1,12 @@ | |||
import { gzipSync } from "zlib"; | |||
|
|||
export default function sizePrinter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking on this one :D
I removed the global If you have on objections, I’ll merge this :) |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
... lol |
really nice thinking on the |
fetch(data uri)
to avoid CSP.Overall, this results in ~6% size savings (621 bytes vs 587 bytes