Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node worker threads #35

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Add support for node worker threads #35

merged 2 commits into from
Sep 23, 2020

Conversation

surma
Copy link
Collaborator

@surma surma commented Aug 21, 2020

Closes #32

@surma surma requested a review from RReverser August 21, 2020 13:05
@surma surma mentioned this pull request Aug 21, 2020
Closed
RReverser
RReverser reviewed Aug 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@surma surma requested a review from RReverser August 21, 2020 15:41
@ngzhian
Copy link

ngzhian commented Aug 26, 2020

LGTM :) Thanks for your work!

@surma
Copy link
Collaborator Author

surma commented Aug 27, 2020

Waiting for a final LGTM from @RReverser who is OOO for a week. So we’ll get back to this :)

@ngzhian
Copy link

ngzhian commented Sep 22, 2020 •
edited

Bump.

RReverser
RReverser approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@RReverser RReverser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd still go with a separate build instead, but fine by me.

@surma
Copy link
Collaborator Author

surma commented Sep 23, 2020

Duly noted, and I think we’ll get back to this discussion, but for now I’d rather keep it simple and predictable. Thanks for LGTM’ing :)

@surma surma merged commit b98ccbf into master Sep 23, 2020
@surma
Copy link
Collaborator Author

surma commented Sep 23, 2020

Published in v1.2.6

@RReverser RReverser deleted the node-workers branch September 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RReverser RReverser RReverser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

threads test does not run correctly in node
3 participants
@surma @ngzhian @RReverser