Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tapPromise to fix Webpack plugin async issues #59

Merged
merged 1 commit into from
May 23, 2023
Merged

Use tapPromise to fix Webpack plugin async issues #59

merged 1 commit into from
May 23, 2023

Conversation

sonkkeli
Copy link
Collaborator

@sonkkeli sonkkeli commented May 22, 2023 •
edited

No description provided.

@sonkkeli sonkkeli requested a review from cmfcmf May 23, 2023 08:13
cmfcmf
cmfcmf approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % small typing nits

packages/webbundle-webpack-plugin/src/index.ts Outdated Show resolved Hide resolved
packages/webbundle-webpack-plugin/src/index.ts Outdated Show resolved Hide resolved
packages/webbundle-webpack-plugin/src/index.ts Outdated Show resolved Hide resolved
@sonkkeli sonkkeli merged commit eab73f0 into GoogleChromeLabs:main May 23, 2023
14 checks passed
@sonkkeli sonkkeli deleted the fix-async-issues branch May 23, 2023 12:14
@sonkkeli sonkkeli changed the title Use tapAsync to fix Webpack plugin async issues Use tapPromise to fix Webpack plugin async issues May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmfcmf cmfcmf cmfcmf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sonkkeli @cmfcmf